fix(ci): close the dependabot ignore gap — all cargo ecosystems, not just root - #319
Merged
Merged
Conversation
…just root Third re-float of the cranelift-isle pin (#298, #310, now #318). The previous fix added a dependabot `ignore` for cranelift-isle, but scoped it to the root cargo ecosystem only. #318 was titled "update cranelift-isle requirement in /fuzz" and widened the ROOT workspace constraint to 0.134 anyway — the bot came in through one of the four doors that were still open: / ignore=[cranelift-isle] /fuzz ignore=NONE <- used this one /loom-cli ignore=NONE /loom-core ignore=NONE /loom-isle ignore=NONE A partial mechanical guard is a guard that has not been tested against the thing it guards. Adding the entry to every cargo ecosystem, and re-pinning the root constraint that #318 widened. This is the same lesson the release gate in v1.3.0 carries, applied to my own previous fix: the invariant has to be enforced everywhere it can be violated, not everywhere I happened to look. Refs #142, #304, #311
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third re-float of the
cranelift-islepin (#298 → #304, #310 → #312, now #318).The guard added in #312 was incomplete: the
ignorewas scoped to the root cargo ecosystem only. #318 — titled "update cranelift-isle requirement in /fuzz" — widened the root workspace constraint to0.134anyway, because/fuzzhad no ignore entry.Adds the entry to every cargo ecosystem and re-pins the root constraint #318 widened.
A partial mechanical guard is not a guard — it just relocates the door. Same lesson as the release floor gate, applied to my own previous fix.
Note: v1.3.0 was tagged at
b69c84b, before #318 landed, so the release carries the correct0.132pin and a verified-green CI. This restores main to match.